Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmavconn: fix UDP deadlocks #1720

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

SylvainPastor
Copy link

Same problems as for the TCP:

Same problems as for the TCP:
  - mavlink#1682: fix std::system_error when tcp interface loses connection
  - mavlink#1679: fix deadlock when call close()
@SylvainPastor
Copy link
Author

SylvainPastor commented Mar 3, 2022

Hello, I can offer you to make changes to the libmavconn library to redo complete tests and refactor the common code between the different types of connections. What do you think ?

Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Test fixes also would be nice!

@vooon vooon merged commit cf95850 into mavlink:ros2 Mar 5, 2022
@vooon vooon added this to the Version 2.2 milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants