plugins: ftp: fix null pointer dereference #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df4e529 mistakenly switched PayloadHeader::data from using a non-standards compliant (but accepted by most compilers) flexible array to a pointer. This resulted in an attempt to dereference the uninitialized contents of the array. This patch eliminates PayloadHeader::data and instead makes FTPRequest::data() use pointer arithmetic to get the data buffer from within the payload buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
df4e529 mistakenly switched
PayloadHeader::datafrom using a non-standards compliant (but accepted by most compilers) flexible array to a pointer. This resulted in an attempt to dereference the uninitialized contents of the array.This patch eliminates
PayloadHeader::dataand instead makesFTPRequest::data()use pointer arithmetic to get the data buffer from within the payload buffer.This fixes the crash, but the plugin still doesn't work quite right, at least with ArduPilot. The only command I have been able to execute successfully is checksum.
Fixes #1695