Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-UAS launch #1835

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Multi-UAS launch #1835

merged 3 commits into from
Mar 2, 2023

Conversation

vacabun
Copy link
Contributor

@vacabun vacabun commented Feb 28, 2023

I find parameters name tgt_system and tgt_component are wrong in the node launch file.

I define namespace for params to control few drones, and write an example lunach file for the multi UAV system.

I have tested the Multi-UAS launch file in simulation environment.

<include file="$(find-pkg-share mavros)/launch/px4.launch">
<arg name="tgt_system" value="$(eval '1 + int(\'$(var id)\') ')" />
<arg name="namespace" value="$(eval ' \'mavros/uas_\' + \'$(var tgt_system)\' ')" />
</include>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more advanced way to achieve that may be done by loading node classes.

1x mavros::router::Router
2x mavros::uas::UAS

But it almost not tested.

@vooon vooon added this to TODO in ROS2 support via automation Mar 1, 2023
@vooon vooon added the fix label Mar 1, 2023
@vooon vooon added this to the Version 2.5 milestone Mar 1, 2023
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

ROS2 support automation moved this from TODO to In Progress Mar 2, 2023
@vooon vooon merged commit 7228a31 into mavlink:ros2 Mar 2, 2023
ROS2 support automation moved this from In Progress to Done Mar 2, 2023
@vacabun vacabun deleted the multi_uas_launch_fix branch March 3, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ROS2 support
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants