New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ROS2 launch parameters namespace and name. #1838

Merged

vooon merged 1 commit into mavlink:ros2 from vacabun:launch_namespace_fix

Mar 8, 2023

Contributor

vacabun commented Mar 7, 2023

The plugin denylist allowlist plugin_allowlist and plugin_denylist.
When change the node's namespace, the plugin parameters cannot be loaded normally.
The parameter file needs to fit into the namespace.
Like this：
```
/mavros/**:
  ros__parameters:
    startup_px4_usb_quirk: false

/mavros/**/conn:
  ros__parameters:
    heartbeat_rate: 1.0    # send heartbeat rate in Hertz
    heartbeat_mav_type: "ONBOARD_CONTROLLER"
```
Use /** to fit the new namespace.
It can alse fit the default namespace mavros.


          fix plugin denylist allowlist name, and fix parameters namespace.

82295e1

vooon approved these changes

View reviewed changes

Member

vooon left a comment

LGTM, Thanks!

vooon added this to the Version 2.5 milestone

vooon added this to TODO in ROS2 support via automation

vooon added the ros2 label

vooon merged commit 01eccd8 into mavlink:ros2

ROS2 support automation moved this from TODO to Done

vacabun deleted the launch_namespace_fix branch

March 8, 2023 03:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment