Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local takeoff and land topics #1890

Merged
merged 3 commits into from
Sep 9, 2023
Merged

local takeoff and land topics #1890

merged 3 commits into from
Sep 9, 2023

Conversation

IdoGuzi
Copy link
Contributor

@IdoGuzi IdoGuzi commented Aug 29, 2023

PR for issue: #1888
Adding topics for local takeoff and landing:
/mavros/cmd/takeoff_local
/mavros/cmd/land_local

Both will take the CommandLocalTOL service type (file: mavros_msgs/srv/CommandLocalTOL.srv)

Creating this as draft as it is not tested properly yet, but it will allow others to test if needed,
I'm expecting to finish testing by the end of the week (ardupilot, pixhawk 6c fcu).

Please comment if something else need to be done for the PR to be approved.

Note: on local land (the mavlink message) https://mavlink.io/en/messages/common.html#MAV_CMD_NAV_LAND_LOCAL
I wasn't sure what Target means (param 1 of the message), let me know how should it be handled.

mavros_msgs/srv/CommandLocalTOL.srv Outdated Show resolved Hide resolved
mavros/src/plugins/command.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thanks!

@vooon vooon added this to the Version 2.6 milestone Sep 4, 2023
@vooon vooon marked this pull request as ready for review September 9, 2023 10:17
@vooon vooon merged commit e44ce06 into mavlink:ros2 Sep 9, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants