Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

children does not check whether returned nodes are nodes #17

Open
adamjanicki2 opened this issue Mar 11, 2024 · 1 comment
Open

children does not check whether returned nodes are nodes #17

adamjanicki2 opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@adamjanicki2
Copy link
Contributor

The children function needs to use the isNode function from the context to check whether nodes are actually nodes

@adamjanicki2 adamjanicki2 added the bug Something isn't working label Mar 11, 2024
@LeaVerou
Copy link
Member

I believe it doesn't do that only when following getChildProperties() (or what replaces it) as a perf optimization, the assumption being that then it's on the author to supply correct information.
That said, it should check that they are truthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants