Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to complete developer interface #7

Merged
merged 17 commits into from
Aug 16, 2021
Merged

Add type hints to complete developer interface #7

merged 17 commits into from
Aug 16, 2021

Conversation

mawassk
Copy link
Owner

@mawassk mawassk commented Aug 16, 2021

No description provided.

@mawassk mawassk added the enhancement New feature or request label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #7 (152c627) into main (3ab2307) will decrease coverage by 0.97%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   93.71%   92.73%   -0.98%     
==========================================
  Files           7        7              
  Lines         175      179       +4     
==========================================
+ Hits          164      166       +2     
- Misses         11       13       +2     
Impacted Files Coverage Δ
ninja_apikey/models.py 95.83% <ø> (ø)
ninja_apikey/security.py 79.54% <71.42%> (-2.96%) ⬇️
ninja_apikey/admin.py 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab2307...152c627. Read the comment docs.

@mawassk mawassk merged commit 6f5c6aa into main Aug 16, 2021
@mawassk mawassk deleted the mypy branch August 16, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant