Bug 365363 - use HTML5 section elements and ARIA landmark roles

max-li · Jan 30, 2012 · 825de9f · 825de9f
1 parent 22eb179
commit 825de9f
Show file tree

Hide file tree

Showing 22 changed files with 44 additions and 40 deletions.
diff --git a/bundles/org.eclipse.orion.client.core/web/compare/compare.html b/bundles/org.eclipse.orion.client.core/web/compare/compare.html
@@ -44,7 +44,7 @@
     <div id="eclipse.compare" dojoType="dijit.layout.BorderContainer" design="headline" liveSplitters="true" persist="true" gutters="false" class="orionPage">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div id = "compareContainer" dojoType="dijit.layout.BorderContainer" design="headline" liveSplitters="false" persist="false" gutters="false" region="center" splitter="false">

diff --git a/bundles/org.eclipse.orion.client.core/web/edit/edit.html b/bundles/org.eclipse.orion.client.core/web/edit/edit.html
@@ -52,7 +52,7 @@
 				<div id="outline"></div>
 			</div>
 		</div>
-		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false">
+		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center" style="overflow:hidden">

diff --git a/bundles/org.eclipse.orion.client.core/web/edit/readonly.html b/bundles/org.eclipse.orion.client.core/web/edit/readonly.html
@@ -49,7 +49,7 @@
 			<div class="auxpane" id="leftPane" dojoType="dijit.layout.ContentPane" open="true" region="leading" style="width: 20%" splitter="true">
 				<div id="outline" style="margin-left: 16px; margin-top: 8px"></div>
 			</div>
-			<div id = "rightPane" dojoType="dijit.layout.ContentPane" region="center" style="overflow: hidden">
+			<div id = "rightPane" dojoType="dijit.layout.ContentPane" region="center" style="overflow: hidden" role="main">
 				<div id="searchFloat" class="searchFloat">
 				</div>
 				<div id="editor" style="width: 100%; height: 100%;">

diff --git a/bundles/org.eclipse.orion.client.core/web/index.html b/bundles/org.eclipse.orion.client.core/web/index.html
@@ -43,7 +43,7 @@
 	<div dojoType="dijit.layout.BorderContainer" design="headline" gutters="false" class="orionPage">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div dojoType="dijit.layout.BorderContainer" design="headline" persist="false" gutters="false" region="center" splitter="false">
+		<div dojoType="dijit.layout.BorderContainer" design="headline" persist="false" gutters="false" region="center" splitter="false" role="main">
 			<!--<div dojoType="dijit.layout.ContentPane" id="feed" region="top" class="mainpane" style="height: 33%">
 				<div dojoType="dojox.widget.FeedPortlet" title="Orion News" id="orionfeed" url="http://planetorion.org/news/feed/" maxResults="5" openNew="false" showFeedTitle="false">
 				</div>		

diff --git a/bundles/org.eclipse.orion.client.core/web/navigate/table.html b/bundles/org.eclipse.orion.client.core/web/navigate/table.html
@@ -54,7 +54,7 @@
 				<div id="favoriteProgress"></div>
 			</div>
 		</div>
-		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false">
+		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="explorer-tree" dojoType="dijit.layout.ContentPane" splitter="false"region="center">

diff --git a/bundles/org.eclipse.orion.client.core/web/operations/list.html b/bundles/org.eclipse.orion.client.core/web/operations/list.html
@@ -41,7 +41,7 @@
 	<div id="orion.pluginsList" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">		

diff --git a/bundles/org.eclipse.orion.client.core/web/orion/breadcrumbs.js b/bundles/org.eclipse.orion.client.core/web/orion/breadcrumbs.js
@@ -84,6 +84,7 @@ define(['require', 'dojo', 'orion/util'], function(require, dojo, mUtil) {
 					dojo.place(document.createTextNode(' >> '), slash, "only");
 					this.path+="/";
 					dojo.addClass(slash, "breadcrumb");
+					dojo.attr(slash, "role", "separator");
 					crumbs.appendChild(slash);
 				} else {
 					// we are at the root.  Get rid of any href since we are already here
@@ -115,6 +116,7 @@ define(['require', 'dojo', 'orion/util'], function(require, dojo, mUtil) {
 						dojo.place(document.createTextNode(' >> '), slash, "only");
 						this.path += '/';
 						dojo.addClass(slash, "breadcrumb");
+						dojo.attr(slash, "role", "separator");
 						crumbs.appendChild(slash);
 					}
 				}

diff --git a/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js b/bundles/org.eclipse.orion.client.core/web/orion/globalCommands.js
@@ -278,29 +278,31 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/extensionCommands',
 
 	// BEGIN TOP BANNER FRAGMENT
 	var topHTMLFragment =
-	//Top row:  Logo + discovery links + user
-	'<div id="staticBanner" class="layoutBlock topRowBanner">' +
-		'<a id="home" class="layoutLeft primaryNav" href="' + require.toUrl("index.html") + '"><img src="' + require.toUrl("images/orion-small-lightondark.gif") + '" alt="Orion Logo"/></a>' +
-		'<div id="primaryNav" class="layoutLeft primaryNav"></div>' +
-		'<div id="help" class="layoutRight help"><a id="help" href="' + require.toUrl("help/index.jsp") + '"><img src="' + require.toUrl("images/help.gif") + '" alt="Help"/></a></div>'+
-		'<div id="userInfo" class="layoutRight primaryNav"></div>' +
-		'<div class="layoutRight primaryNav">|</div>' +
-	'</div>' +
-	//Title area
-	'<div id="titleArea" class="layoutBlock titleArea">' +
-		'<div id="pageTitle" class="layoutLeft pageTitle"></div>' +
-		'<input type="search" id="search" placeholder="Search root" title="Type a keyword or wild card to search in root" class="layoutRight searchbox">' +
-		'<div id="relatedLinks" class="layoutRight pageNav"></div>' +
-		'<div id="globalActions" class="layoutRight pageNav"></div>' +
-		'<div id="dimension" class="layoutBlock dimension"></div>' +
-		'<div id="location" class="layoutBlock currentLocation"></div>' +
-	'</div>';
+	'<header role="banner">' + 
+		//Top row:  Logo + discovery links + user
+		'<div id="staticBanner" class="layoutBlock topRowBanner">' +
+			'<a id="home" class="layoutLeft primaryNav" href="' + require.toUrl("index.html") + '"><img src="' + require.toUrl("images/orion-small-lightondark.gif") + '" alt="Orion Logo"/></a>' +
+			'<nav id="primaryNav" class="layoutLeft primaryNav" role="navigation"></nav>' +
+			'<div id="help" class="layoutRight help"><a id="help" href="' + require.toUrl("help/index.jsp") + '"><img src="' + require.toUrl("images/help.gif") + '" alt="Help"/></a></div>'+
+			'<div id="userInfo" class="layoutRight primaryNav"></div>' +
+			'<div class="layoutRight primaryNav">|</div>' +
+		'</div>' +
+		//Title area
+		'<div id="titleArea" class="layoutBlock titleArea">' +
+			'<div id="pageTitle" class="layoutLeft pageTitle"></div>' +
+			'<input type="search" id="search" placeholder="Search root" title="Type a keyword or wild card to search in root" class="layoutRight searchbox" role="search">' +
+			'<div id="relatedLinks" class="layoutRight pageNav"></div>' +
+			'<div id="globalActions" class="layoutRight pageNav"></div>' +
+			'<div id="dimension" class="layoutBlock dimension"></div>' +
+			'<div id="location" class="layoutBlock currentLocation"></div>' +
+		'</div>' +
+	'</header>';
 	// END TOP BANNER FRAGMENT
 
 	// BEGIN BOTTOM BANNER FRAGMENT
 	// styling of the surrounding div (text-align, etc) is in ide.css "footer"
 	var bottomHTMLFragment = 
-		'<div class="layoutBlock">' +
+		'<footer class="layoutBlock" role="contentinfo">' +
 			'<div class="footerBlock">' +
 				'This is a Beta build of Orion. Please try it out but BEWARE your data may be lost.' +
 			'</div>' +
@@ -312,7 +314,7 @@ define(['require', 'dojo', 'dijit', 'orion/commands', 'orion/extensionCommands',
 				'<a href="http://www.eclipse.org/legal/copyright.php" target="_blank">Copyright Agent</a> | '+
 				'<a href="' + require.toUrl("/operations/list.html") +'" target="_blank">Server Operations</a>' +
 			'</div>' +
-		'</div>';
+		'</footer>';
 	// END BOTTOM BANNER FRAGEMENT
 
 	var toolbarFragment = 

diff --git a/bundles/org.eclipse.orion.client.core/web/orion/widgets/templates/OpenResourceDialog.html b/bundles/org.eclipse.orion.client.core/web/orion/widgets/templates/OpenResourceDialog.html
@@ -6,7 +6,7 @@
 		</span>
 	</div>
 	<div dojoAttachPoint="containerNode" class="dijitDialogPaneContent">
-		<div style="display:table">
+		<div style="display:table" role="search">
 			<div style="display:table-row">
 				<div style="display:table-cell; padding:5;">
 					<label for="resourceName" style="padding-right:10">${selectFile}</label>

diff --git a/bundles/org.eclipse.orion.client.core/web/plugin/list.html b/bundles/org.eclipse.orion.client.core/web/plugin/list.html
@@ -40,7 +40,7 @@
 	<div id="orion.pluginsList" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">		

diff --git a/bundles/org.eclipse.orion.client.core/web/search/search.html b/bundles/org.eclipse.orion.client.core/web/search/search.html
@@ -52,7 +52,7 @@
 				<div id="favoriteProgress" class="auxPadding"></div>
 			</div>
 		</div>
-		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false">
+		<div id="rightPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="results" tabindex="0" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false">

diff --git a/bundles/org.eclipse.orion.client.core/web/settings/settings.html b/bundles/org.eclipse.orion.client.core/web/settings/settings.html
@@ -34,7 +34,7 @@
 		<div id="orion.settings" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 			<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 			</div>
-			<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" gutters="false" design="headline" liveSplitters="false" splitter="false">
+			<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" gutters="false" design="headline" liveSplitters="false" splitter="false" role="main">
 				<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 				</div>
 				<div class="auxpane" id="categories" dojoType="dijit.layout.ContentPane" splitter="false" region="leading" style="width: 150px">

diff --git a/bundles/org.eclipse.orion.client.core/web/sites/site.html b/bundles/org.eclipse.orion.client.core/web/sites/site.html
@@ -40,7 +40,7 @@
 	<div id="eclipse.edit-site" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" gutters="false" design="headline" liveSplitters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" gutters="false" design="headline" liveSplitters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="site" dojoType="dijit.layout.ContentPane" splitter="false"region="center">

diff --git a/bundles/org.eclipse.orion.client.core/web/sites/sites.html b/bundles/org.eclipse.orion.client.core/web/sites/sites.html
@@ -41,7 +41,7 @@
 	<div id="eclipse.sites" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" gutters="false" region="center" design="headline" liveSplitters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" gutters="false" region="center" design="headline" liveSplitters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="site-table" dojoType="dijit.layout.ContentPane" splitter="false"region="center">

diff --git a/bundles/org.eclipse.orion.client.core/web/test/unittest.html b/bundles/org.eclipse.orion.client.core/web/test/unittest.html
@@ -49,7 +49,7 @@
 		<div dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
-			<div class="mainpane" id="rightPane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">
+			<div class="mainpane" id="rightPane" dojoType="dijit.layout.ContentPane" splitter="false" region="center" role="main">
 				<div id="test-overview">
 					<!-- info about test goes here -->
 				</div>

diff --git a/bundles/org.eclipse.orion.client.git/web/git/git-clone.html b/bundles/org.eclipse.orion.client.git/web/git/git-clone.html
@@ -53,7 +53,7 @@
 				</div>
 			</div>
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" splitter="false" gutters="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainPane" id="explorer-tree" dojoType="dijit.layout.ContentPane" splitter="false" region="center">

diff --git a/bundles/org.eclipse.orion.client.git/web/git/git-commit.html b/bundles/org.eclipse.orion.client.git/web/git/git-commit.html
@@ -43,7 +43,7 @@
 	<div id="orion.git-commit" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">		

diff --git a/bundles/org.eclipse.orion.client.git/web/git/git-log.html b/bundles/org.eclipse.orion.client.git/web/git/git-log.html
@@ -44,7 +44,7 @@
  	<div id="orion.gitlog" class="orionPage" dojoType="orion.widgets.eWebBorderContainerReverse" design="headline" liveSplitters="true" persist="true" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="explorer-tree" dojoType="dijit.layout.ContentPane" splitter="false"region="center">

diff --git a/bundles/org.eclipse.orion.client.git/web/git/git-repository.html b/bundles/org.eclipse.orion.client.git/web/git/git-repository.html
@@ -47,7 +47,7 @@
 	<div id="orion.repository" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">		

diff --git a/bundles/org.eclipse.orion.client.git/web/git/git-status.html b/bundles/org.eclipse.orion.client.git/web/git/git-status.html
@@ -43,7 +43,7 @@
 	<div id="eclipse.git-status" class="orionPage" dojoType="orion.widgets.eWebBorderContainer" design="headline" gutters="false" liveSplitters="true">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="leftPane" dojoType="dijit.layout.BorderContainer" region="leading" design="headline" style="width: 40%" liveSplitters="false" gutters="false" splitter="true">
+		<div id="leftPane" dojoType="dijit.layout.BorderContainer" region="leading" design="headline" style="width: 40%" liveSplitters="false" gutters="false" splitter="true" role="main">
 			<div id="pageToolbar" class="auxToolbar" dojoType="dijit.layout.ContentPane" region="top" splitter="false">
 			</div>
 			<div id="gitStatusPane" class="auxpane" dojoType="dijit.layout.ContentPane" region="center" splitter="false">				

diff --git a/bundles/org.eclipse.orion.client.users.ui/web/profile/user-list.html b/bundles/org.eclipse.orion.client.users.ui/web/profile/user-list.html
@@ -44,7 +44,7 @@
 	<div id="orion.profile" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" liveSplitters="false" gutters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" id="usersPane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">	

diff --git a/bundles/org.eclipse.orion.client.users.ui/web/profile/user-profile.html b/bundles/org.eclipse.orion.client.users.ui/web/profile/user-profile.html
@@ -43,12 +43,12 @@
 	<div id="orion.profile" class="orionPage" dojoType="dijit.layout.BorderContainer" design="headline" gutters="false">
 		<div class="banner" id="banner" dojoType="dijit.layout.ContentPane" region="top">
 		</div>
-		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" gutters="false" liveSplitters="false" splitter="false">
+		<div id="centerPane" dojoType="dijit.layout.BorderContainer" region="center" design="headline" gutters="false" liveSplitters="false" splitter="false" role="main">
 			<div class="toolbar" id="pageToolbar" dojoType="dijit.layout.ContentPane" splitter="false" region="top">
 			</div>
 			<div class="mainpane" dojoType="dijit.layout.ContentPane" splitter="false"region="center">	
 				<table><tr>
-				<td id="profileContent" class="mainPadding">
+				<td id="profileContent" class="mainPadding" role="form">
 					<div>Loading user profile...</div>
 				</td>	
 				</tr>