Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded variables jwt_header and jwt_grant #17

Closed
wants to merge 1 commit into from

Conversation

RekGRpth
Copy link
Contributor

No description provided.

@pjz
Copy link

pjz commented Mar 4, 2022

Any idea when/if this will be merged? I'd like to use it, and a merge would avoid me setting up my own fork and etc.

@RekGRpth
Copy link
Contributor Author

RekGRpth commented Mar 5, 2022

Any idea when/if this will be merged? I'd like to use it, and a merge would avoid me setting up my own fork and etc.

Try use https://github.com/maxam18/nginx-ejwt-module instead

@max-lt
Copy link
Owner

max-lt commented Mar 5, 2022

It won't be, as this PR came with no description, no example case, no tests, no comments.

The added code does't fit the project style and is a bit obscure; 2 of 4 functions are copy-pasted of the 2 others and I think it can be done much more cleanly. I tried to clear this up at the time but finaly gave up.

Furthermore, I don't see any interest in getting JWT variables in the Nginx context (except for logging, maybe ?). I think that making security operations in this scope (if that's your idea) may be tricky (especially with the few tools Nginx provides, remember : if is evil).

Feel free to fork the project from this point and improve it.

@max-lt max-lt closed this Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants