to-string numbers written to the stream

max-mapper · Sep 1, 2016 · 3e285ba · 3e285ba · ChALkeR · Sep 1, 2016
1 parent 4ca83d6
commit 3e285ba
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -73,6 +73,10 @@ function isArrayish (arr) {
   return /Array\]$/.test(Object.prototype.toString.call(arr))
 }
 
+function isBufferish (p) {
+  return typeof p === 'string' || isArrayish(p) || (p && typeof p.subarray === 'function')
+}
+
 function stringConcat (parts) {
   var strings = []
   var needsToString = false
@@ -82,8 +86,10 @@ function stringConcat (parts) {
       strings.push(p)
     } else if (Buffer.isBuffer(p)) {
       strings.push(p)
-    } else {
+    } else if (isBufferish(p)) {
       strings.push(new Buffer(p))
+    } else {
+      strings.push(new Buffer(String(p)))
     }
   }
   if (Buffer.isBuffer(parts[0])) {
@@ -101,10 +107,11 @@ function bufferConcat (parts) {
     var p = parts[i]
     if (Buffer.isBuffer(p)) {
       bufs.push(p)
-    } else if (typeof p === 'string' || isArrayish(p)
-    || (p && typeof p.subarray === 'function')) {
+    } else if (isBufferish(p)) {
       bufs.push(new Buffer(p))
-    } else bufs.push(new Buffer(String(p)))
+    } else {
+      bufs.push(new Buffer(String(p)))
+    }
   }
   return Buffer.concat(bufs)
 }

diff --git a/test/string.js b/test/string.js
@@ -58,7 +58,7 @@ test('string from buffers with multibyte characters', function (t) {
   var snowman = new Buffer('☃')
   for (var i = 0; i < 8; i++) {
     strings.write(snowman.slice(0, 1))
-    strings.write(snowman.slice(1))    
+    strings.write(snowman.slice(1))
   }
   strings.end()
 })
@@ -74,3 +74,14 @@ test('string infer encoding with empty string chunk', function (t) {
   strings.write("dogs")
   strings.end()
 })
+
+test('to string numbers', function (t) {
+  var write = concat(function (str) {
+    t.equal(str, 'a1000')
+    t.end()
+  })
+
+  write.write('a')
+  write.write(1000)
+  write.end()
+})