-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle errors without err callback argument #6
Comments
Cc @substack (I will respond in more detail later) Sent from my iPhone On May 25, 2013, at 12:18 AM, Jo Liss notifications@github.com wrote:
|
i'd also like to hear the story behind it |
sorry about the lag on responding! so originally I had an stream.on('error', handleError) all gonna close this for now but feel free to re-open if this description isn't logical |
I can't say I'm convinced, though handling errors separately isn't hard work I'd be inclined to stick with the older version because its more normal to me |
Hm, I'd be worried that people just forget to attach error handlers. Anyways, I'll defer to your judgment. |
The following code:
throws
Before d530532, I believe there would have been an
err
argument to the callback.It seems a bit surprising to me to have no
err
argument to the callback. Is there a nice way to handle errors now? Or should we bring theerr
argument back maybe?The text was updated successfully, but these errors were encountered: