Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests failing #251

Closed
rvagg opened this issue Jun 24, 2014 · 2 comments
Closed

Functional tests failing #251

rvagg opened this issue Jun 24, 2014 · 2 comments

Comments

@rvagg
Copy link
Member

rvagg commented Jun 24, 2014

Got no time right now to look in to this, would love someone to put up their hand to figure out why 0.18.4 is broken: https://travis-ci.org/rvagg/node-levelup/builds/28288083

@dominictarr
Copy link
Contributor

okay I have reproduced this locally (with a fresh install...)
this is very weird. somewhere it is throwing a buffer!

@dominictarr
Copy link
Contributor

I found it. downgrading to concat-stream@0.1 to fixes this.
the problem is that in concat stream the first argument isn't an error.
there is an issue describing it here: max-mapper/concat-stream#6

Now, I would have probably still used an always null error arg for consistency with node patterns.

rvagg added a commit that referenced this issue Jun 25, 2014
@rvagg rvagg closed this as completed in be2fcb3 Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants