Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows 10 pro] Application getting cutoff if taskbar is vertical #298

Open
tboulis opened this issue Sep 17, 2020 · 4 comments
Open

[Windows 10 pro] Application getting cutoff if taskbar is vertical #298

tboulis opened this issue Sep 17, 2020 · 4 comments

Comments

@tboulis
Copy link

tboulis commented Sep 17, 2020

Description

The menubar window is not full visible (bottom is getting cut off) with this arrangement:

  • Windows 10 Pro
  • 3 monitors (1 laptop, 2 standalone)
  • Windows task bar is on the right side of the screen (vertical)

The hidden part of the app has roughly 200px height

Specifications

  • Menubar version: 9.0.1
  • Platform: Windows 10 Pro version 1083
  • Electron version: 9.2.1

Other information

Could be related to this PR: #217

Screenshot

image

@tboulis
Copy link
Author

tboulis commented Sep 17, 2020

@amaurymartiny fyi

@semenov-oleg
Copy link
Contributor

@amaurymartiny I've found that the following code is responsible for this issue
https://github.com/maxogden/menubar/blob/master/src/Menubar.ts#L180-L193
Could you explain please what is the reason to optimize vertical position? Maybe would another way be more effective?

@amaury1093
Copy link
Collaborator

Yes, I believe that code was written before I became maintainer.

Maybe would another way be more effective?

Feel free to improve with a PR!

@semenov-oleg
Copy link
Contributor

Ok. I'm going to remove this code. I've checked locally on Windows with 2 monitors. Seems that project works fine without this 'optimization'

semenov-oleg pushed a commit to semenov-oleg/menubar that referenced this issue Nov 24, 2020
amaury1093 pushed a commit that referenced this issue Jan 20, 2021
* Improve 'windows' OS detection of taskbar location
Should be helpful for the following issues
#264
#232

* Update windows position before windows displaying
Referring to the issue
#232

* Improve 'windows' OS detection of taskbar location (fix multi-monitor systems)

* Fix lint issues

* Removed win32 vertical optimization
Trying to solve issue:
#298

Co-authored-by: Oleg Semenov <oleg.semenov@theyr.com>
JaeBradle added a commit to JaeBradle/menubar that referenced this issue Oct 19, 2022
* Improve 'windows' OS detection of taskbar location
Should be helpful for the following issues
max-mapper/menubar#264
max-mapper/menubar#232

* Update windows position before windows displaying
Referring to the issue
max-mapper/menubar#232

* Improve 'windows' OS detection of taskbar location (fix multi-monitor systems)

* Fix lint issues

* Removed win32 vertical optimization
Trying to solve issue:
max-mapper/menubar#298

Co-authored-by: Oleg Semenov <oleg.semenov@theyr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants