Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always open menubar app on clicked screen #31

Merged

Conversation

fabien-d
Copy link
Collaborator

@fabien-d fabien-d commented Jul 7, 2015

What does this PR do?

  • Open the menubar app on the screen that was clicked, not always the focused one.
  • Separate the workaround so it can easily be removed if/when electron fixes in core.

How should this be manually tested?

Open the menubar example app on separate displays with various configuration (vertically stacked, horizontally stacked) and make sure it always aligns properly

What are the relevant issues?

@fabien-d
Copy link
Collaborator Author

Updated with a Windows fix for #32. Appears if when the bounds get set, the y value doesn't take the app height into consideration.

@tommoor
Copy link

tommoor commented Jul 26, 2015

Would be useful for muan/mojibar#3 - any problems with this one @maxogden ?

@max-mapper
Copy link
Owner

Sorry missed this one. LGTM

@fabien-d
Copy link
Collaborator Author

We've been using this code in a production app for a few weeks and no bugs have been reported since.

fabien-d added a commit that referenced this pull request Jul 27, 2015
@fabien-d fabien-d merged commit 17a4c62 into max-mapper:master Jul 27, 2015
@fabien-d fabien-d deleted the workaround_electron_display_focus branch July 27, 2015 15:13
@eazydripz
Copy link

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants