Do not override the destroy method, use _destroy instead
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
commented
Oct 19, 2017
| if (this._destroyed) return | ||
| this._destroyed = true | ||
|
|
||
| proxy._destroy = function(err, cb) { |
There was a problem hiding this comment.
Using the default implementation with
this.push(null)
this.end()is probably better but I didn't change it as there might be something I'm missing here.
lpinca
commented
Oct 19, 2017
| @@ -155,7 +150,7 @@ function WebSocketStream(target, protocols, options) { | |||
|
|
|||
| function onmessage(event) { | |||
| var data = event.data | |||
| if (data instanceof ArrayBuffer) data = Buffer.from(new Uint8Array(data)) | |||
There was a problem hiding this comment.
This change is unrelated and not needed but there is no need to instantiate a new Uint8Array. You can use the ArrayBuffer directly.
I can revert this change or move it to its own commit/PR if wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform.destroy()is now available inreadable-stream, so I think it makes sense to use it properly.