Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature [Star] #26

Merged
merged 4 commits into from
Oct 24, 2020
Merged

New feature [Star] #26

merged 4 commits into from
Oct 24, 2020

Conversation

worachatsun
Copy link
Contributor

Screen Shot 2563-10-24 at 01 52 16

@max-programming
Copy link
Owner

Does starring push it to the top?

@max-programming
Copy link
Owner

max-programming commented Oct 23, 2020 •
edited
Loading

image
btw, this is the warning. Oh that's my issue. Lemme clear that first.

Done. Now you can pull and I'll merge it. Thanks a lot

@max-programming
Copy link
Owner

Thank you so much!

@worachatsun
Copy link
Contributor Author

Please wait. I have to fix some order logic.

@max-programming max-programming merged commit 255c775 into max-programming:master Oct 24, 2020
@max-programming max-programming mentioned this pull request Oct 24, 2020
Merged
@max-programming
Copy link
Owner

Please wait. I have to fix some order logic.

You can create a new pull request now. It was merged and then reverted

@worachatsun
Copy link
Contributor Author

@max-programming Could you please add hacktoberfest-accepted tag in my PR?

#28
#20
#19
#18
#26

@max-programming
Copy link
Owner

@worachatsun You don't need that label. As my repo has the hacktoberfest topic. And the PR is merged. It's accepted by hacktoberfest.
Read this: https://hacktoberfest.digitalocean.com/hacktoberfest-update
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worachatsun @max-programming