Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple edit todo functionality #4

Merged
merged 1 commit into from Oct 9, 2020
Merged

Added simple edit todo functionality #4

merged 1 commit into from Oct 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2020

No description provided.

@@ -58,6 +58,16 @@ function App() {
setTodos([...todos, newTodo]);
}
};
const editTodo = (id) => {
let text = window.prompt('Edit Todo', '');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now but it is not good to use merge. Maybe you can create a modal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on that!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a Pull so that you keep up with the latest code. Thanks for the edit functionality

@max-programming max-programming merged commit c2c90a2 into max-programming:master Oct 9, 2020
@max-programming
Copy link
Owner

Very very important feature! Thanks a lot Nicholas!!! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant