Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build an arm64 container image #11

Merged

Conversation

silverlyra
Copy link
Contributor

@silverlyra silverlyra commented Sep 8, 2022

👋🏻 Hello! Thank you for this project. 😄 I’m going to be deploying this to my clusters at work, but I need to run it on arm64 nodes.

This updates the Dockerfile to support cross-compiling the Go binary to a different target platform, and adds a Makefile which uses docker buildx to create amd64 and arm64 images and a multi-arch image manifest to tie them together.

If you’ve not built multi-architecture images before, this guide is a good starting point for what needs to be set up on the host system.

@max-rocket-internet
Copy link
Owner

Thanks @silverlyra, like it!

Could you add a new section in the README that shows what make command to run to build it? Is that how it's used?

@silverlyra
Copy link
Contributor Author

Hi @max-rocket-internet – I was hoping you’d start building multi-arch images and pushing them to your Docker Hub, so that users could just install them. 😄

I could add an (e.g.) BUILDING.md with Docker build instructions?

@max-rocket-internet
Copy link
Owner

I was hoping you’d start building multi-arch images and pushing them to your Docker Hub, so that users could just install them. 😄

I am 100% ready to do this! I just don't get what the makefile does. In my experience it's used for running make build or whatever.

I could add an (e.g.) BUILDING.md with Docker build instructions?

No need for another file, just add another heading under Installation in the README called "Building" and put the required make command there or any relevant info.

@silverlyra
Copy link
Contributor Author

@max-rocket-internet done

Copy link
Owner

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you @silverlyra 🔥

@max-rocket-internet max-rocket-internet merged commit 75c6e25 into max-rocket-internet:master Sep 16, 2022
@silverlyra silverlyra deleted the arm64-images branch September 19, 2022 05:31
@silverlyra silverlyra restored the arm64-images branch September 19, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants