Skip to content

Commit

Permalink
test: more RDBMS integration tests in CI (PRQL#2286)
Browse files Browse the repository at this point in the history
* -added docker compose
-added test skeleton

* -added dependencies

* -added real test cases

* -added mssql

* refactoring

* -added go-task

* -more testcases

* -added github workflow

* -fixed formatting

* -fixed linting

* -fixed workflow yaml

* -fixed workflow yaml again

* -added more testcases

* Apply suggestions from code review

Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>

* -refactored test workflow

* Fix order of args to `assert_display_snapshot`

Sorry for the incorrect suggestion prior!

* Specify platform for mysql image

* -added csv import

* -fixed or skipped all prql files

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* -fixed sqlite

* added snaps§

* Update prql-compiler/prqlc/src/cli.rs

* -removed test on macOS

* empty

* -skip integration test on windows

* -fixed taskfile

* -added double quotes

* Update .github/workflows/test-rust.yaml

---------

Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Co-authored-by: Maximilian Roos <m@maxroos.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
  • Loading branch information
5 people committed Apr 2, 2023
1 parent cc1f3b9 commit 03c335d
Show file tree
Hide file tree
Showing 26 changed files with 1,576 additions and 46 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/test-rust.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ jobs:
with:
command: test
args: ${{ inputs.target_option }} --no-run --locked
- name: Run docker compose
run: docker compose up -d
working-directory: ./prql-compiler/tests/integration-rdbms
if: ${{ inputs.os == 'ubuntu-latest' }}
- name: Wait for database
uses: ifaxity/wait-on-action@v1
with:
resource: "tcp:5432 tcp:3306 tcp:1433"
timeout: 60000
if: ${{ inputs.os == 'ubuntu-latest' }}
- name: skip integration if not linux
run: echo "SKIP_INTEGRATION=true" >> "$GITHUB_ENV"
if: ${{ inputs.os != 'ubuntu-latest' }}
# Only check unreferenced snapshots on the default target tests on ubuntu
#
# (Maybe there's a nicer approach where we can parameterize one step
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-taskfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-taskfile
cancel-in-progress: true

env:
SKIP_INTEGRATION: true

jobs:
test-taskfile:
runs-on: macos-latest
Expand Down
Loading

0 comments on commit 03c335d

Please sign in to comment.