Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor variables and ensure that *-test.xml files are created even if no problems found >> master #2

Merged
merged 5 commits into from
May 15, 2014

Conversation

nickboldt
Copy link
Collaborator

No description provided.

@maxandersen
Copy link
Owner

I was about to merge this in when noticed that it now includes what seem to be incomplete code for handling component owners...shouldn't we split that into seprate PR instead of mixing that in with the rename of variables and test.xml generation ? ...or is the component code considered ready to merge ?

…rt sending mail to all component owners when no assignees set; tweak email copy & refactor some variables
@nickboldt
Copy link
Collaborator Author

It's ready for review & to be applied now, thanks.

for component in fields['components']:
# print component['id']
# https://issues.jboss.org/rest/api/2/component/12311294
component_data = jiraquery(options, "/rest/api/2/component/" + component['id'])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we query at least once per issue...could be cached for component. But we can do that in separate PR as improvement.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just ran this - this makes it incredibly slow actually ;/

@maxandersen maxandersen merged commit 5d58cdf into maxandersen:master May 15, 2014
}
},
{
"No fix version": {
"jql": "project in (JBIDE,JBDS) AND fixVersion is EMPTY AND resolution is EMPTY and createdDate <= -7d",
"description": "please triage this issue that are more than 7 days old."
"description": "please triage this issue - it is more than 7 days old and has no fix version or assignee."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only has has no fixv ersion. it might well be assigned.

@maxandersen
Copy link
Owner

i've merged this in including caching of components and fixes for other comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants