fix(tdhttp): (*tdhttp.TestApi).CmpJSONBody(nil) panicked

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
maxatome · Sep 12, 2021 · 8a1c3c4 · 8a1c3c4
1 parent 13e0c61
commit 8a1c3c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/helpers/tdhttp/test_api.go b/helpers/tdhttp/test_api.go
@@ -711,6 +711,9 @@ func (t *TestAPI) cmpMarshaledBody(
 		}
 	} else {
 		bodyType = reflect.TypeOf(expectedBody)
+		if bodyType == nil {
+			bodyType = types.Interface
+		}
 	}
 
 	// For unmarshaling below, body must be a pointer

diff --git a/helpers/tdhttp/test_api_test.go b/helpers/tdhttp/test_api_test.go
@@ -253,6 +253,16 @@ bingo%CR
 		}
 
 		mockT := tdutil.NewT("test")
+		td.CmpFalse(t,
+			tdhttp.NewTestAPI(mockT, mux).
+				NewJSONRequest("GET", "/mirror/json", json.RawMessage(`null`)).
+				CmpStatus(200).
+				CmpHeader(containsKey).
+				CmpJSONBody(nil).
+				Failed())
+		td.CmpEmpty(t, mockT.LogBuf())
+
+		mockT = tdutil.NewT("test")
 		td.CmpFalse(t,
 			tdhttp.NewTestAPI(mockT, mux).
 				NewJSONRequest("ZIP", "/any/json", requestBody).