feat: add (*td.T).Parallel() method #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1024399179
💛 - Coveralls |
maxatome
reviewed
Jul 12, 2021
abhinav
changed the title
Add a Parallel() method to `*td.T` that calls `Parallel()` on the underlying `testing.TB` if it supports the method. This will have no effect on `*testing.B` or custom wrappers that do not support `Parallel()`. Per #149, this implements this as a method rather than a top-level `td.Parallel(t)` function because this is closer to what existing usage of `*testing.T` looks like. Resolves #149
|
Comments incorporated and commit message updated. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Parallel() method to
*td.Tthat callsParallel()on theunderlying
testing.TBif it supports the method. This will have noeffect on
*testing.Bor custom wrappers that do not supportParallel().Per #149, this implements this as a method rather than a top-level
td.Parallel(t)function because this is closer to what existing usageof
*testing.Tlooks like.Resolves #149