Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Len/Cap): Len & Cap could not be used in JSON #167

Merged
merged 1 commit into from
Sep 3, 2021
Merged

fix(Len/Cap): Len & Cap could not be used in JSON #167

merged 1 commit into from
Sep 3, 2021

Conversation

maxatome
Copy link
Owner

@maxatome maxatome commented Sep 2, 2021

because JSON uses float64 and Len/Cap expected int.

Len and Cap now accept any number type, not only int as before.

@coveralls
Copy link

coveralls commented Sep 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1195154679

  • 45 of 45 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 99.848%
Totals Coverage Status
Change from base Build 1187889562: 0.0005%
Covered Lines: 9184
Relevant Lines: 9198
💛 - Coveralls

@maxatome
fix(Len/Cap): Len & Cap could not be used in JSON
6e446e6 
because JSON uses float64 and Len/Cap expected int.

Len and Cap now accept any number type, not only int as before.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome maxatome merged commit ae551b1 into master Sep 3, 2021
@maxatome maxatome deleted the len-cap branch September 3, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-roussel c-roussel c-roussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxatome @coveralls @c-roussel