Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JSON): same behavior for embedded & placeholder operators #174

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

maxatome
Copy link
Owner

Now:

td.JSON(`{"foo": $1}`, td.Between(12, 34))
td.JSON(`{"foo": Between($1, $2)}`, 12, 34)

act the same way. Since v1.10.1 rework, the second was not working as
expected.

At the same time:

td.JSON(`{"foo": Between(12, 34, $1)}`, td.BoundsOutIn)

now works as expected. It was rejected before.

Now:

    td.JSON(`{"foo": $1}`, td.Between(12, 34))
    td.JSON(`{"foo": Between($1, $2)}`, 12, 34)

act the same way. Since v1.10.1 rework, the second was not working as
expected.

At the same time:

    td.JSON(`{"foo": Between(12, 34, $1)}`, td.BoundsOutIn)

now works as expected. It was rejected before.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1375590300

  • 52 of 52 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0004%) to 99.849%

Totals Coverage Status
Change from base Build 1279725928: 0.0004%
Covered Lines: 9245
Relevant Lines: 9259

💛 - Coveralls

@maxatome maxatome merged commit 8d1e455 into master Oct 23, 2021
@maxatome maxatome deleted the fix-json branch October 23, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants