Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Between(FROM, TO): if FROM is a time.Time, TO can now be a time.Duration #175

Merged
merged 5 commits into from
Oct 24, 2021
Merged

Between(FROM, TO): if FROM is a time.Time, TO can now be a time.Duration #175

merged 5 commits into from
Oct 24, 2021

Conversation

maxatome
Copy link
Owner

No description provided.

@maxatome
style: add //go:build line when // +build is already present
7bf51ef 
New syntax of go1.17.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome
feat: handle go1.17 []T → *[n]T convertibility edge case
132b428 
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome
feat(Between): accept time.Duration as TO when FROM is a time.Time
3c26fe4 
and add an example.

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome
refactor(JSON): factorize code
695e5b7 
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome
fix: some examples was not tested
963aac2 
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1378202718

  • 65 of 65 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0006%) to 99.849%
Totals Coverage Status
Change from base Build 1375601774: 0.0006%
Covered Lines: 9283
Relevant Lines: 9297
💛 - Coveralls

@maxatome maxatome merged commit 80fe99e into master Oct 24, 2021
@maxatome maxatome deleted the between-time branch October 24, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxatome @coveralls