feat: replacing bytes.Buffer instances used only to generate strings with strings.Builder.

[ellisonleao]

Ref #223

[coveralls]

Coverage increased (+4.0e-05%) to 99.861% when pulling 44305f9 on ellisonleao:issue-223 into 06e96ce on maxatome:master.

[maxatome]

Hello, thanks for your PR!

a few small things:

• could you also handle:
  • internal/json/lex.go:267
  • internal/util/string.go:83 renaming SliceToBuffer to SliceToString
• could you change your commit message to

  refactor: string generation uses strings.Builder when possible
  
  Closes #224
  

[ellisonleao]

done @maxatome

[maxatome]

My bad, by renaming SliceToBuffer to SliceToString I also meant changing the signature from using *bytes.Buffer to *strings.Builder. Sorry.

[ellisonleao]

@maxatome any suggestions on how to handle buf.Truncate() and buf.Bytes(), since they don't exist in strings.Builder?

[maxatome]

• buf.Bytes() is used by bytes.LastIndexByte so it can be replaced by buf.String() and strings.LastIndexByte;
• buf.Truncate() call can be avoided by reworking the preceding loop:

  buf.WriteString(IndentString(ToString(items[0]), prefix))
  for _, item := range items[1:] {
    buf.WriteString(",\n")
    buf.WriteString(prefix)
    buf.WriteString(IndentString(ToString(item), prefix))
  }

  (not tested :) )

[ellisonleao]

done @maxatome

[maxatome]

Thanks a lot @ellisonleao ! 😉 And welcome as go-testdeep contributor.