Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Request Assertions for http fake #2

Merged
merged 4 commits into from
Jun 11, 2020
Merged

Adds Request Assertions for http fake #2

merged 4 commits into from
Jun 11, 2020

Conversation

erutherford
Copy link
Collaborator

What

  • the functionality should be good to go, should maybe add more tests and more examples, but I wanted to get this up so that we could start discussing it

@maxcnunes
Copy link
Owner

It looks great! Let me know when it is ready to be merged.

@erutherford
Copy link
Collaborator Author

@maxcnunes I think this should be ready to go, let me know if you'd like to see anything changed on the README updates I made.

@maxcnunes maxcnunes merged commit c8179db into maxcnunes:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcnunes maxcnunes Awaiting requested review from maxcnunes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erutherford @maxcnunes