ensure login test models correct behavior #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of tower-sessions `0.12.1`, we addressed a potential security issue related to cycling session IDs. A side effect of that fix is that we uncovered incorrect modeling of the login behavior within our login test in axum-login. Our login test is intended to assert, among other things, that a successful login will cycle the session ID. Previously, we checked that the original session ID and the new session ID did not match. However, this assumed behavior of tower-sessions that was incorrect (cycling an ID should in fact set the session ID to `None`). Instead, the session ID is only updated once the session is saved, e.g. by the tower-sessions middleware, when it resolves a response. Here we've addressed this by more closely modeling the middleware. Closes #215.
maxcountryman
force-pushed
the
test-login
branch
3 times, most recently
from
70d4bb3
to
3a94749
Compare
maxcountryman
force-pushed
the
test-login
branch
from
3a94749
to
b4df3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of tower-sessions
0.12.1, we addressed a potential security issue related to cycling session IDs. A side effect of that fix is that we uncovered incorrect modeling of the login behavior within our login test in axum-login.Our login test is intended to assert, among other things, that a successful login will cycle the session ID. Previously, we checked that the original session ID and the new session ID did not match. However, this assumed behavior of tower-sessions that was incorrect (cycling an ID should in fact set the session ID to
None). Instead, the session ID is only updated once the session is saved, e.g. by the tower-sessions middleware, when it resolves a response.Here we've addressed this by more closely modeling the middleware.
Closes #215.