Ability to force host used when redirecting #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flask-Login's default unauthorized handler uses
Flask.redirect
to redirect to the login page. When a request is made to a route decorated with@login_required
, thenFlask.redirect
correctly uses theHost
orX-Forwarded-For
as the host part of the redirect url.This is fine, except in SSO applications or pen-tests. For those who don't mind breaking proxies, this PR adds a new config
FORCE_HOST_FOR_REDIRECTS
that always overwrites the host inflask_login.utils.login_url
which is used when redirecting to the login url.