-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility with Werkzeug 2.2 and Flask 2.2 #691
Conversation
Fixes compatibility with Flask 2.2
I'd like to point out that this seriously breaks anyone who has a user_loader or request_loader - which I believe are public API entry points. While Flask 2.2 is going to deprecate using _app_ctx_stack - this change immediately forces anyone to either only support this latest version or do checks to see whether _login_user attribute is set. In any case - thanks so much for keeping this package alive and up to date. |
You should not be checking any internal values directly. This change should be invisible to the user. If you don't believe that's the case, open a discussion about that. |
Actually I have a strong case supporting it, This will break openid integration for users of Airlfow using google open id integration. It's not your fault of course here @davidism - it's the client's fault, but I just wanted you to know that it does affect your users (I am openinig discussion momentarily). |
|
app.url_value_preprocessor
andapp.url_defaults
, not by trying to re-parse the rule on every build.fixes incompatible with werkzeug 2.2.0, can't import parse_rule #686
g._login_user
instead of_app_ctx_stack.top.user
.fixes use
g
instead of_app_ctx_stack
for Flask 2.2 compat #690