Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming Tfoot to TFoot (as TBody / THead) #621

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Renaming Tfoot to TFoot (as TBody / THead) #621

merged 1 commit into from
Oct 25, 2021

Conversation

oderwat
Copy link
Sponsor Contributor

@oderwat oderwat commented Oct 22, 2021

I think the naming of the tags should be consistent. I tripped over Tfoot vs THead.

maxence-charriere
maxence-charriere requested changes Oct 25, 2021
View reviewed changes
Copy link
Owner

@maxence-charriere maxence-charriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Look like you may have a different format than mine with the js file. Since that file is not modified, can you just avoid including it in the PR?

@maxence-charriere maxence-charriere merged commit e00cb4c into maxence-charriere:master Oct 25, 2021
@oderwat
Copy link
Sponsor Contributor Author

oderwat commented Oct 25, 2021

I am not sure what is up with the script. I try to think on removing it in the future. Still, why is it different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxence-charriere maxence-charriere maxence-charriere requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oderwat @maxence-charriere