Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed checkbox to radio button for clearer UI. #210

Merged

Conversation

joshheyse
Copy link
Contributor

@joshheyse joshheyse commented Jan 31, 2021

I was a little confused when I first created a secret. This should make requiresAuthentication clearer to the user.
Fixes #209

Copy link
Owner

@maxgoedjen maxgoedjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a question + suggestion. Thanks for doing this!

Secretive/Views/CreateSecretView.swift Show resolved Hide resolved
Secretive/Views/CreateSecretView.swift Show resolved Hide resolved
Secretive/Views/CreateSecretView.swift Show resolved Hide resolved
Secretive/Views/CreateSecretView.swift Outdated Show resolved Hide resolved
@joshheyse
Copy link
Contributor Author

Previous View

Screen Shot 2021-01-30 at 10 20 18 PM

Updated with label
Screen Shot 2021-01-30 at 10 21 41 PM

@maxgoedjen
Copy link
Owner

maxgoedjen commented Jan 31, 2021

Looks great, I put back the empty text (think you made the right call there). Thanks for helping make the app better! 🙏 I'll merge this once the CI checks pass.

@maxgoedjen maxgoedjen merged commit 42b0342 into maxgoedjen:main Jan 31, 2021
@joshheyse
Copy link
Contributor Author

Happy to help. Thanks for the project!

@maxgoedjen
Copy link
Owner

@joshheyse this is now out in 2.1.1, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve wording around auth requirements during secret creation
2 participants