fix(utils): capture step_cli attempt to open tty (#72) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll await your fixes to the CI checks, or assume you'll let me know if you need somthing else. Thanks. |
eengstrom
force-pushed
the
capture-step-cli-tty-error
branch
from
cc99885
to
05d0b35
Compare
|
Squashed and rebased off of your |
|
I just pushed the finished branch onto main, so all CI tests should once again pass (including linting). Could you rebase this PR against main please? |
This workaround captures a different or updated error message
from `step-cli` when it attempts to open `/dev/tty`:
open /dev/tty: no such device or address
Ideally, `step-cli` would provide a way to avoid this entirely; c.f:
- smallstep/cli#502
eengstrom
force-pushed
the
capture-step-cli-tty-error
branch
from
05d0b35
to
c5dcc48
Compare
|
Rebased - fingers crossed that all tests pass - thanks for all your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix captures a different or updated error message from
step-cliwhen it attempts to open/dev/tty:Ideally,
step-cliwould provide a way to avoid this entirely; c.f:/resolves #72