Remove unnessessary pop from http client bytes parsing

maximdanilchenko · Nov 8, 2023 · f3721df · f3721df
1 parent 2a78ea9
commit f3721df
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/aiochclient/http_clients/aiohttp.py b/aiochclient/http_clients/aiohttp.py
@@ -30,10 +30,11 @@ async def post_return_lines(
             buffer: bytes = b''
             async for chunk in resp.content.iter_any():
                 lines: List[bytes] = chunk.split(self.line_separator)
-                lines[0] = buffer + lines[0]
-                buffer = lines.pop(-1)
-                for line in lines:
+                if buffer:
+                    lines[0] = buffer + lines[0]
+                for line in lines[:-1]:
                     yield line + self.line_separator
+                buffer = lines[-1]
             assert not buffer
 
     async def post_no_return(

diff --git a/aiochclient/http_clients/httpx.py b/aiochclient/http_clients/httpx.py
@@ -30,10 +30,11 @@ async def post_return_lines(
         buffer: bytes = b''
         async for chunk in resp.aiter_bytes():
             lines: List[bytes] = chunk.split(self.line_separator)
-            lines[0] = buffer + lines[0]
-            buffer = lines.pop(-1)
-            for line in lines:
+            if buffer:
+                lines[0] = buffer + lines[0]
+            for line in lines[:-1]:
                 yield line + self.line_separator
+            buffer = lines[-1]
         assert not buffer
 
     async def post_no_return(