-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert from file #109
Insert from file #109
Conversation
Btw thanks for the contribution! Very useful method. |
@maximdanilchenko should i change something so that you merge this PR? |
aiochclient/client.py
Outdated
async def insert_file( | ||
self, | ||
query: str, | ||
filepath: str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making it not a path str, but a file obj to make it possible to use it for instance in web servers when someone want to get file by web?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made updates and now method has file_obj
param
Sorry, made a comment, but forgot to submit review |
No description provided.