Deprecate TwigCollector and friends #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't actually remove it, only deprecate it, without breaking BC. |
|
oh ops, should add |
TraceableTwigEnvironment and TraceableTwigTemplate
|
@barryvdh updated, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning behind this merge is to get rid of the
TwigCollector, which seems to work only fortwig/twig <2.Since there is an alternative
TwigProfileCollectorwhich seems to work throughout v1 and v2 of Twig, I have updated the demo to use that instead.And also cleaned the bridge documentation to reflect the now absent
TwigCollector.This fixes #423. WDYT @barryvdh?