Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window close for frameless window not working #553

Closed
coder-ashwin opened this issue Nov 13, 2020 · 6 comments
Closed

window close for frameless window not working #553

coder-ashwin opened this issue Nov 13, 2020 · 6 comments

Comments

@coder-ashwin
Copy link

coder-ashwin commented Nov 13, 2020

when the window is frameless, I am not able to close the window programmatically using electron.remote.getCurrrentWindow().close() and also not throwing any errors but the minimize function works electron.remote.getCurrrentWindow().minimize(). And also the close function works for windows with frames. Also, this used to work for frameless windowsas well in your previous version which I took around 5 months back (July 2020).

@j-loriault
Copy link

works for me. I'm building a frameless window with custom title bar and min/max/close icons (via font awesome)

@j-loriault
Copy link

j-loriault commented Nov 18, 2020

try this video, hes using an older branch I believe, but its what I based mine on and it works for me:

https://www.youtube.com/watch?v=Ea2lWsumTrM&list=PLHNb3f8cN49Hud29vfjGNFBMzCs90BnuR&index=1&t=2022s

its the mods to the electron service he makes I think that makes it work

@coder-ashwin
Copy link
Author

@SolariceMedia That's what I am saying it worked for me also in that older branch but its not working in the latest one. P.S: I also followed that video while using the older branch.

@j-loriault
Copy link

hmm dunno then, works perfectly for me

@stale
Copy link

stale bot commented Dec 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 16, 2020
@whyboris
Copy link
Contributor

I have a frameless app Video Hub App and it seems to close correctly with this code:

import { BrowserWindow } from 'electron';
BrowserWindow.getFocusedWindow().close();

@stale stale bot removed the wontfix label Dec 17, 2020
@stale stale bot added the wontfix label Jan 2, 2021
@stale stale bot closed this as completed Jan 9, 2021
Repository owner deleted a comment from stale bot Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants