Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coherent notification list #23

Merged

Conversation

nreynis
Copy link

@nreynis nreynis commented Jan 12, 2018

All templates now get the same object and use the same parameter name.
Entities become JsonSerializable.

Nicolas Reynis added 2 commits January 12, 2018 16:20
@nreynis
Copy link
Author

nreynis commented Jan 12, 2018

I forgot to mention it, but there is a slightly breaking change in notification_list.html.twig:
The notification item in notificationList must now be accessed by key notification instead of index 0

@maximilienGilet
Copy link
Owner

Interesting feature, I think it will be implemented in a 3.0 version

Thanks for the contribution

@maximilienGilet maximilienGilet added this to the 3.0 milestone Jan 26, 2018
@maximilienGilet maximilienGilet changed the base branch from master to dev April 15, 2018 20:57
@maximilienGilet maximilienGilet merged commit 339935f into maximilienGilet:dev Apr 15, 2018
@maximilienGilet
Copy link
Owner

Merged in dev branch.

Dev branch is for upcoming 3.0 version.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants