Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StaticMapsEngine.GenerateStaticMapURL accept encode path #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rainmakerho
Copy link

  1. Modify sample codes in readme.md (Query => QueryAsync ...)
  2. Modify StaticMapsEngine.GenerateStaticMapURL method, accept encode path

an encoded polyline using the enc: prefix within the location declaration of the path
add use EncodePolyline example
@maximn
Copy link
Owner

maximn commented Aug 31, 2023

modify readme.md commit also have some code file changes (spacing). please remove.

@@ -28,13 +28,13 @@ public string GenerateStaticMapURL(StaticMapRequest request)

var parametersList = new QueryStringParametersList();

if (!string.IsNullOrEmpty(request.ApiKey))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional? If not, please revert.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual Studio automatically formatting it.
Could you tell me how to revert?

};
var geocodingEngine = GoogleMaps.Geocode;
GeocodingResponse geocode = geocodingEngine.Query(geocodeRequest);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this should be part of this commit? Seems like unrelated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IEngineFacade only have QueryAsync method, so GeocodingResponse geocode = geocodingEngine.Query(geocodeRequest); should be changed to var geocode = await geocodingEngine.QueryAsync(geocodeRequest);

});
Console.WriteLine("Map with path: " + url);

//use EncodePath
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Owner

@maximn maximn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants