implemented editing for existing servers and improved getting a list …

…of existing repos for a user (fixes #4)
maximtrp · Dec 20, 2023 · fa39cf2 · fa39cf2
1 parent c54a9fe
commit fa39cf2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## 2.0.1 - 2023-12-20
+
+- Editing server details is now possible.
+- Replaced `getRepos` API call with `selfRepos`. This should fix the extension behavior with restricted Drone CI setups.
+
 ## 2.0.0 - 2023-11-10
 
 - Refactored server operations (add, edit, delete, select).

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "drone-ci",
   "displayName": "Drone CI",
   "description": "Manage your Drone CI servers easily",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "publisher": "maximtrp",
   "author": {
     "name": "Maksim Terpilovskii",

diff --git a/src/repos.ts b/src/repos.ts
@@ -51,7 +51,7 @@ export class ReposProvider implements vscode.TreeDataProvider<Repo> {
       let repos: RepoInfo[] = [];
 
       try {
-        repos = (await this.client.getRepos()) || [];
+        repos = (await this.client.selfRepos()) || [];
         if (repos.length > 0) {
           const sortField: string =
             vscode.workspace.getConfiguration("drone-ci.sortRepos").get("by") || "Name";

diff --git a/src/servers.ts b/src/servers.ts
@@ -83,12 +83,6 @@ export class ServersProvider implements vscode.TreeDataProvider<Server> {
     if (!url) {
       vscode.window.showWarningMessage(`You have not entered Drone CI server address`);
       return;
-    } else {
-      const serverExists = this.servers.find((server) => server.url === url);
-      if (serverExists) {
-        vscode.window.showErrorMessage("Server with this URL already exists");
-        return;
-      }
     }
 
     const label = await vscode.window.showInputBox({
@@ -106,7 +100,7 @@ export class ServersProvider implements vscode.TreeDataProvider<Server> {
       })) || server.token;
 
     const serverNew: ServerInfo = {
-      id: this.servers.length.toString(),
+      id: server.id,
       url: url,
       token: token,
       label: label || url.replace("https://", ""),