Plot improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24 +/- ##
===========================================
+ Coverage 96.25% 96.42% +0.17%
===========================================
Files 6 6
Lines 347 364 +17
Branches 60 64 +4
===========================================
+ Hits 334 351 +17
Misses 1 1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
maximz
force-pushed
the
plot-improvements
branch
from
07b5644
to
23490d8
Compare
maximz
force-pushed
the
plot-improvements
branch
from
233781a
to
b77a802
Compare
…t(). Rationale: we may want to run scatterplot() twice against the same ax, with different z-orders (or other HVS params) for the two collections of data. Simply passing a zorder kwarg doesn't work because HVS supplies a default style zorder kwarg too, i.e. we'd be calling ax.scatter with two conflicting zorder kwargs.
…acters like slashes.
…ing compared against. For example, a numerical category #8 will be converted to a string label '8'. To get sample size of that numerical category, we need to cast back to int first.
maximz
force-pushed
the
plot-improvements
branch
from
09c6034
to
b1437c8
Compare
maximz
force-pushed
the
plot-improvements
branch
from
b1437c8
to
d301804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary courtesy of GPT-4:
Enhancements and New Features in
scatterplot:hue_keyto beNone.marker_zorder,marker_size_scale_factor,legend_size_scale_factor,marker_face_color, andmarker_linewidths.hue_keyisNone.New Utility Functions:
superimpose_group_labelsfunction to overlay group labels on a plot, moving away from directly including this within thescatterplotfunction.add_sample_size_to_legendto append sample sizes to legend labels in scatter plots.Improvements in Plot Customization and Utility:
wrap_tick_labelswith options for better text wrapping, including specifying characters that encourage line breaks.normalize_rowsandnormalize_columnsregarding handling rows or columns with all zeroes, indicating that such cases will result in NaNs.