-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cbSuccessMsg is no more taken into account #299
Comments
When testing with cbOnSuccess callback, if found that adding a callback fix the missing field (in the event provided to the callback method and in the global event queue)
|
It is by design.
|
Thx for the quick response ! My issue is that we observe the global ClipboardService.copyResponse$ to avoid defining a callback for each ngxClipboard instance, and the event does not contain the successMessage field. Would it be possible to enrich the event even if no local callback is registered ? Something as :
|
totally, welcome to make a PR I will merge it. thx! |
see #300 |
This issue is closed as part of Pull Request #300. Please close the issue. |
issue fixed by #300 |
Starting from release 15.0.x of ngx-clipboard, assigning a string to the field cbSuccessMsg on the button no longer add it on the IClipboardResponse event generated.
eg:
The text was updated successfully, but these errors were encountered: