Verify working on .NET 7 Preview & all LTS versions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkagamine
commented
Jul 4, 2022
| Action verifyFooPostedStuff = () => handler.VerifyRequest(HttpMethod.Post, fooUrl, | ||
| async r => (await r.Content.ReadAsStringAsync()) == "stuff"); | ||
| Action verifyFooPostedOtherStuff = () => handler.VerifyRequest(HttpMethod.Post, fooUrl, | ||
| async r => (await r.Content.ReadAsStringAsync()) == "other stuff", failMessage: "oh noes"); |
There was a problem hiding this comment.
It seems in .NET Framework the HttpRequestMessage gets disposed, which prevents us from accessing the request body in Verify. That said, these overloads aren't especially useful anyway; they were generated alongside the SetupRequest methods, but the match predicate is meant for setups, so it's probably safe to leave them out (and avoid encouraging their use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest .NET 7 preview introduces a breaking change to the StringContent constructor where it no longer accepts null for
mediaType(dotnet/runtime#63231). ReturnsResponse has been updated to default to text/plain (which is still StringContent's default when themediaTypeparameter is not used). Fixes #9.To better catch these sorts of problems in the future, the unit tests will now run against the latest/preview .NET version, every LTS version, and legacy .NET Framework. Unfortunately this still needs to be updated manually. Currently the frameworks that are tested are: