-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Provide withButtonView across all views/dialogs #50
Comments
Which event would trigger the selection then if the button view is not wanted for the views, via a separate invocation to trigger it via the use-case state? |
Yes, a separate invocation via the use-case state would work. |
Great issue and a change I welcome much as well. |
Here's an example:
|
@maxkeppeler onPositiveClick is still a required option even though there can be no buttons now. InfoView(
useCaseState = rememberUseCaseState(),
selection = InfoSelection(withButtonView = false)
)
|
It's often the case that buttons are not needed at all. For example, bottom sheets already have a convenient way to dismiss them, so a positive button is not needed. Using the view (InfoView, etc) counterparts have more use cases of not needing a button such as providing buttons elsewhere or using animations.
Providing
withButtonView
across all dialogs would be good, or allowing the positive button to be null.Use case 1:
I want my own button so that I can animate it
Use case 2:
This is a bottom sheet only for information so I don't need any buttons. The user can just swipe it away
The text was updated successfully, but these errors were encountered: