Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashes on configuration change #24

Closed
mohamadjavadx opened this issue Jan 2, 2021 · 2 comments
Closed

crashes on configuration change #24

mohamadjavadx opened this issue Jan 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mohamadjavadx
Copy link

Describe the bug
the sample app crashes on configuration change while showing some bottom-sheets

Library Version:
1.1.1

To Reproduce
open a multipleChoices bottom-sheet and rotate phone

Expected behavior
the app should not crash and also app should maintain state of bottom-sheet and selected options

Additional context
maybe some navigationComponent-ish changes could help

@mohamadjavadx mohamadjavadx added the bug Something isn't working label Jan 2, 2021
@maxkeppeler
Copy link
Owner

maxkeppeler commented Jan 2, 2021

Found the issue. You are right, instead of calling the bottom sheet again, the bottom sheet should maintain the state and data and show up again after the configuration change. Will work on it soon.

@mohamadjavadx
Copy link
Author

thanks for quick response, also check out fragment new dependency (1.3.0-rc01) it's pretty much stable and provide new ways to do things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants