Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OptionSheet icons to be in colour #83

Closed
russellbanks opened this issue Aug 18, 2021 · 4 comments
Closed

Allow OptionSheet icons to be in colour #83

russellbanks opened this issue Aug 18, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@russellbanks
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Icons get converted into black and white when in an Options Sheet meaning that either custom icons that use colour will look odd or a second variation that is a black outline is required for the sheet.

Describe the solution you'd like
A function that allows the option to either have the icons in an Options Sheet in black and white or in colour.

Describe alternatives you've considered
I have got around this problem elsewhere by making a custom sheet that uses icons in colour however it would be nice to have the option for icons in colour for the Options Sheet.

Additional context
I have attached a video showing this - I have had to provide a black outlined icon whereas it would be nice to show it in colour within the sheet.

21-08-18-17-48-29.mp4
@russellbanks russellbanks added the enhancement New feature or request label Aug 18, 2021
@maxkeppeler
Copy link
Owner

maxkeppeler commented Aug 22, 2021

Are the following methods not exactly doing this?

defaultIconColor(...)
defaultIconColorRes(...)
defaultIconColor(...)
defaultTitleColor(...)
defaultTitleColorRes(...)
defaultSubtitleColor(...)
defaultSubtitleColorRes(...)

If those individual option colors are not used, the Style attribute ```sheetsIconsColor``' is used next.
You can see a working example, where each option has a different color, in my Aquafy app.

If I misunderstood your requirement, just reopen the issue!

@russellbanks
Copy link
Contributor Author

russellbanks commented Aug 22, 2021

I'm not sure whether I've misunderstood this but from looking at Aquafy and using those functions, it tints the icon whereas my intended idea is to have the image in full colour within the sheet. This means that it can contain many different colours. The defaultIconColor() is good for example for Google Icons, but not for ones on Flaticon (where I get some of my icons from).

To use the example from the video, I have this icon and I would like to show it in the sheet in full color. It contains roughly nine colours in it, so using defaultIconColor merely tints the whole thing to that colour.

I have attached a clearer picture below that shows my issue.

66430095-c42c-4133-a2f2-41e98350913c

@maxkeppeler
Copy link
Owner

Hmm now I start to get it. The drawable you provide should keep its colors - no tint should be applied. So a simple method to keep the drawable as it is without applying a tint will do the job, right?

Do you want this globally for all icons in an OptionsSheet or for each Option you added to it?

@maxkeppeler maxkeppeler reopened this Aug 22, 2021
@russellbanks
Copy link
Contributor Author

Yep, a simple method to keep the drawable as it is without applying a tint would be great, thank you!

For my aim, I'd only need it globally set within an OptionsSheet for uniformity. However, if it's possible to have both, it could mean that there is more customisability for other developers that may have that aim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants