WIP: Remove static IP and use host network. #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a big change and will result in a minor version bump. Removing the assumption on IP addresses will make most of the setup quite easy and remove all the hardcoded IPs. The places which necessarily do require one can be based of 127.0.0.1, like MAILMAN_HOST in Hyperkitty, which verifies the sender based on the incoming IP address.
maxking
changed the title
|
Instead of ripping of the networking, use the usual networking but also expose the port and bind them to the localhost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change and will result in a minor version bump. Removing the
assumption on IP addresses will make most of the setup quite easy and remove
all the hardcoded IPs.
The places which necessarily do require one can be based of 127.0.0.1, like
MAILMAN_HOST in Hyperkitty, which verifies the sender based on the incoming IP
address.