Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one o… #636

Merged
merged 2 commits into from
Jun 20, 2023
Merged

EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one o… #636

merged 2 commits into from
Jun 20, 2023

Conversation

raph-topo
Copy link
Contributor

@raph-topo raph-topo commented Jun 19, 2023 •
edited

Fix #624 like this?

maxking
maxking reviewed Jun 20, 2023
View reviewed changes
Copy link
Owner

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use backticks for variables.

web/README.md Outdated Show resolved Hide resolved
web/README.md Show resolved Hide resolved
@maxking
Copy link
Owner

maxking commented Jun 20, 2023

Overall, lgtm! Added backticks to the variables.

@maxking maxking enabled auto-merge June 20, 2023 02:54
@maxking maxking merged commit 0745e37 into maxking:main Jun 20, 2023
2 checks passed
@raph-topo
Copy link
Contributor Author

Thanks! (I copy-pasted from the Django error message as is.)

@raph-topo raph-topo deleted the patch-5 branch June 20, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxking maxking maxking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] mailman-web: EMAIL_USE_TLS/EMAIL_USE_SSL
2 participants
@raph-topo @maxking