Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASGI support #6

Closed
vytas7 opened this issue Mar 14, 2022 · 0 comments · Fixed by #10
Closed

ASGI support #6

vytas7 opened this issue Mar 14, 2022 · 0 comments · Fixed by #10
Labels
enhancement New feature or request

Comments

@vytas7
Copy link

vytas7 commented Mar 14, 2022

Since HTMLResponseMiddleware doesn't seem to perform any taxing I/O, one could implement ASGI support by simply wrapping the current logic via async def process_response_async(...).
@maxking maxking added the enhancement New feature or request label Mar 14, 2022
maxking added a commit that referenced this issue Mar 14, 2022
@maxking
Add basic support for ASGI.
ced12db 
Reuse the sync handler for the async one too since there isn't a lot of I/O
going on.

Fixes #6
@maxking maxking mentioned this issue Mar 14, 2022
Merged
@maxking maxking mentioned this issue Mar 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add basic support for ASGI. maxking/falcon-api-browse
2 participants
@maxking @vytas7