Add support for Basic authentication #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Edimax SP-1101W uses the Basic authentication scheme, add support and auto detection to use this scheme.
|
Thanks a lot for adding Basic auth support! Unfortunately, I don't have an SP-1101W to test this myself, so I'm just gonna assume that it's fine. The diff looks good. I've released your changed on npm in v1.1.0 |
Confirmed on v1.1.0 it's working. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Edimax SP-1101W uses the Basic authentication scheme, add support and auto detection to use this scheme.
I've tested this with the SP-1101W but don't have access to any other devices that support the Digest authentication mechanism.